Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 2.6 is not supported anymore #8022

Closed
tagliala opened this issue Jul 23, 2023 · 0 comments · Fixed by #8023
Closed

Ruby 2.6 is not supported anymore #8022

tagliala opened this issue Jul 23, 2023 · 0 comments · Fixed by #8023

Comments

@tagliala
Copy link
Contributor

Did you find a bug?

ActiveAdmin is supposed to work with Ruby 2.6, as per gemspec

activeadmin/activeadmin.gemspec

Line 23 in 8ed827b

s.required_ruby_version = ">= 2.6"

Expected behavior

Works

Actual behavior

Does not work, because Ransack 4 requires Ruby 2.7

Also, this going unnoticed because CI is not testing against all supported ruby versions

How to reproduce

Attempt to bundle with 2.6

BUNDLE_GEMFILE=gemfiles/rails_61/Gemfile bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Could not find compatible versions

Because every version of activeadmin depends on ransack >= 4.0, < 5
  and ransack >= 3.1.0 depends on Ruby >= 2.7,
  every version of activeadmin requires Ruby >= 2.7.
So, because Gemfile depends on activeadmin >= 0
  and current Ruby version is = 2.6.10,
  version solving has failed.
tagliala added a commit to tagliala/activeadmin that referenced this issue Jul 23, 2023
@tagliala
Drop support for Ruby 2.6
7ba385e 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

Also test against 2.7 in CI

Close activeadmin#8022
tagliala added a commit to tagliala/activeadmin that referenced this issue Jul 23, 2023
@tagliala
Drop support for Ruby 2.6
6772ec3 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

Also test against 2.7 in CI

Close activeadmin#8022
@tagliala tagliala mentioned this issue Jul 23, 2023
Merged
javierjulio pushed a commit to tagliala/activeadmin that referenced this issue Jul 24, 2023
@tagliala @javierjulio
Drop support for Ruby 2.6
32452fc 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

Also test against 2.7 in CI

Close activeadmin#8022
tagliala added a commit to tagliala/activeadmin that referenced this issue Jul 25, 2023
@tagliala
Drop support for Ruby 2.6
6abb9cf 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

Close activeadmin#8022
tagliala added a commit to tagliala/activeadmin that referenced this issue Jul 25, 2023
@tagliala
Drop support for Ruby 2.6
e0099d0 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

It has been decided not to test against 2.7 because it is in EOL

Close activeadmin#8022
tagliala added a commit to tagliala/activeadmin that referenced this issue Jul 25, 2023
@tagliala
Drop support for Ruby 2.6
c2bcea0 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

It has been decided not to run CI tests against 2.7 because it is in EOL

Close activeadmin#8022
javierjulio pushed a commit that referenced this issue Jul 25, 2023
@tagliala
Drop support for Ruby 2.6 (#8023)
2692838 
Ransack 4 requires Ruby 2.7, so ActiveAdmin 3.x series does not support
Ruby 2.6 already and this commit fixes the misleading gemspec version

It has been decided not to run CI tests against 2.7 because it is in EOL

Close #8022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for Ruby 2.6 tagliala/activeadmin
1 participant
@tagliala