Fix breadcrumb for Mongoid #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also have a fix for Mongoid embedded documents, which can't be queried directly, but I'll wait for this pull request to merge. |
|
Hello @jpmckinney, could you rebase this PR against master? Cheers |
|
Hmm, not sure if that's what you wanted. I can open a new pull request if necessary. |
|
Oh, nevermind, the diff still looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB has hexidecimal IDs. The breadcrumb helper assumes numeric IDs. This very small edit fixes that assumption, while maintaining behavior for Active Record usage.