Code style refactor #1546
Merged
Code style refactor #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ def initialize(html, table_css_selector = "table") | |||
| end | |||
|
|
|||
| def to_array | |||
| rows = Nokogiri::HTML(@html).css("#{@selector} tr") | |||
| rows = Nokogiri::HTML(@html).css("#@selector tr") | |||
There was a problem hiding this comment.
Not many people know the conditions under which braces can be omitted. It's clearer to leave the {} in. Most projects do.
| @@ -17,7 +17,7 @@ def filter(method, options = {}) | |||
|
|
|||
| # Returns the default filter type for a given attribute | |||
| def default_input_type(method, options = {}) | |||
| if column = column_for(method) | |||
| if (column = column_for(method)) | |||
There was a problem hiding this comment.
I don't usually do this. I guess it's a matter of taste? :)
There was a problem hiding this comment.
Maybe :) Everyone follows his style. But Github recommends doing so https://github.com/styleguide/ruby/. In this particular case may be obvious whether a value is assigned to a variable or two variables are compared. You decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.