New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better defaults for the Show page #2138
Conversation
implementig the spec from @seanlinsley in #2138
test will follow |
184c677
to
c86c239
Compare
implementig the spec from @seanlinsley in #2138
c86c239
to
694b36f
Compare
implementig the spec from @seanlinsley in #2138
We to do a banking change here. The old attributes_table foo: 1, bar: 2 But this collides with the possibility to set options ( attributes_table [foo: 1, foo: 2]
attributes_table [{foo: 1, foo: 2}] How should we deal with that? |
694b36f
to
65297a0
Compare
The object would always be the first element: attributes_table foo: 1, bar: 2
attributes_table({foo: 1, bar: 2}, except: [:foo]) |
4377eb4
to
99b61df
Compare
99b61df
to
6f6cd8c
Compare
It looks like this PR removes the ability to pass in a Hash, but as I said above, it's not necessary to drop that feature. |
I propose to close this as incomplete (insufficient tests) and abandoned. Sean thought it could be salvaged but Timo was not convinced. I looked at finishing this myself but the benefit is minor and I don't think it is worth it. |
@varyonic , agree |
I'll turn this into a PR once there's code to go along with the idea.
This replaces the stale #1077.