Don't delete :if and :unless from filters

[PChambino]

Filter :if and :unless options were being deleted and thus only used for the first request.

[seanlinsley]

What version of AA are you using?

[seanlinsley]

Scratch that; I can reproduce locally

[seanlinsley]

I think this would be a better solution:

diff --git a/lib/active_admin/filters/resource_extension.rb b/lib/active_admin/filters/resource_extension.rb
index d348083..c0eac93 100644
--- a/lib/active_admin/filters/resource_extension.rb
+++ b/lib/active_admin/filters/resource_extension.rb
@@ -76,7 +76,7 @@ module ActiveAdmin
       # Collapses the waveform, if you will, of which filters should be displayed.
       # Removes filters and adds in default filters as desired.
       def filter_lookup
-        filters = @filters.try(:dup) || {}
+        filters = @filters.try(:deep_dup) || {}

Since the whole point of using delete was to pass a clean set of options down the line.

[PChambino]

Yes, that looks like a better solution then.

[seanlinsley]

Could you add a test to confirm the bug is fixed?

[PChambino]

Sure. I will look into that.

[coveralls]

Coverage remained the same when pulling 809630a496fa292768ee9ccbc77d5a971be69be5 on PChambino:patch-1 into 82ff48d on gregbell:master.

[seanlinsley]

Looks good, thanks. One more thing: can you squash this into a single commit with a good commit message?

[PChambino]

Is something like this ok?

[coveralls]

Coverage remained the same when pulling ab519e6 on PChambino:patch-1 into 8fa7914 on gregbell:master.

[seanlinsley]

Perfect. Thanks for the contribution!