Allow min/max dates to be set on datepicker input #2578
Conversation
|
Sorry, I initially thought you were setting up a filter. 😓 |
|
The problem is that the |
|
Fixed and updated. Thanks @daxter! |
| range_opts = options.slice(:min_date, :max_date) | ||
| # convert the min and max date values to strings if they aren't already | ||
| range_opts.merge!(range_opts) { |k,v| v.to_s } | ||
| end |
There was a problem hiding this comment.
I've never seen Hash#merge use a block before; what's happening here?
Are you sure that it's necessary to coerce the dates into strings?
There was a problem hiding this comment.
It basically maps all the values in the hash, keeping them on their
respective keys. Kind of a Hash#map, except it stays a hash. If I don't
coerce to strings, the data values show up as ""2013-10-16"". The double
quotes are weird, and they cant be read by datepicker.
There was a problem hiding this comment.
I think it's clearer to just iterate over it:
def datepicker_options
options = options.slice :min_date, :max_date
options.each{ |k,v| options[k] = v.to_s }
endThere was a problem hiding this comment.
Cool, I can change that in the morning.
|
Tested this out locally, works with the button panel and the date ranges, though the button panel shows up has disembodied buttons. They show up, but they should probably have some kind of background on them. |
|
Is there anything holding this back from being merged in? Or is it just an issue of time to test it out? |
|
Yeah, I've been rather scatterbrained lately 🐈 |
| it 'should generate a datepicker text input with data min and max dates' do | ||
| body.should have_tag("input", :attributes => { :type => "text", | ||
| :class => "datepicker", | ||
| :name => "post[created_at", |
There was a problem hiding this comment.
Hmm, how is this test passing? The name parameter is missing a ]
There was a problem hiding this comment.
Yeah, that's pretty weird. Fixed it below. Maybe the matcher is really forgiving or was able to infer the right name?
There was a problem hiding this comment.
I'm betting this would still pass if it was "post[creat". Just string matching on the HTML output.
|
Actually I bet it's using string matching on the html output. Technically it matches correctly, just not completely. |
|
Looks good to me, but can you squash these commits? |
|
I just tried checking locally to see if merging #2645 would prevent your PR from being able to be automatically merged, and it worked fine. But the GitHub UI is telling me that this can't be automatically merged, so I guess that means that GitHub is incapable of doing recursive merges. Could you also rebase this on master? 😅 |
Allows :max_date and :min_date options (or other jQueryUI datepicker
options) to be passed to :datepicker input.
```ruby
f.input :starts_at, as: :datepicker, datepicker_options: {min_date:
"2013-10-8", max_date: 3.days.from_now.to_date}
f.input :ends_at, as: :datepicker, datepicker_options: {min_date:
3.days.ago.to_date, max_date: "+1W +5D"}
```
|
Actually, just noticed I'm no longer converting |
|
I guess it must. The spec is passing. I guess maybe I don't need to coerce |
|
Given: f.input :foo, as: :datepicker, datepicker_options: {
min_date: "2013-10-8",
max_date: 3.days.from_now.to_date
}I get: Wait, what? Thursday? Shouldn't it be Wednesday? 3.days.from_now.to_date # => Thu, 07 Nov 2013Hmm. So it seems to be working without the Though is it me or is the font size larger for the disabled dates? |
|
Meh, that can be dealt with later. Thanks for creating this PR :] |
|
Daylight savings time? Looks like they're a different font weight and smaller, since they're underlined. Also considering adding this to the docs on forms: DatePickerActiveAdmin offers the form do |f|
f.input :starts_at, as: :datepicker, datepicker_options: { min_date: "2013-10-8", max_date: 3.days.from_now.to_date }
f.input :ends_at, as: :datepicker, datepicker_options: { min_date: 3.days.ago.to_date, max_date: "+1W +5D" }
endThoughts? |
Allow min/max dates to be set on datepicker input
|
Yeah, we should definitely have this in the form docs. |
|
Documentation in #2653. |
|
yep :] |
Allows :max_date and :min_date options to be passed to :datepicker input.