Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor DependencyError #3344

Merged
merged 1 commit into from
Aug 20, 2014
Merged

refactor DependencyError #3344

merged 1 commit into from
Aug 20, 2014

Conversation

timoschilling
Copy link
Member

No description provided.

@seanlinsley
Copy link
Contributor

¯_(ツ)_/¯

seanlinsley
seanlinsley reviewed Aug 19, 2014
View reviewed changes
lib/active_admin/error.rb
@@ -51,6 +51,9 @@ def self.database_error_classes
end
end

class DependencyError < ErrorLoading

class NoMenuError < KeyError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an end

@timoschilling
Copy link
Member Author

I have fixed that. That cam from a rebase confligt.

seanlinsley added a commit that referenced this pull request Aug 20, 2014
@seanlinsley
Merge pull request #3344 from timoschilling/dependency_error
ffa68b3 
refactor DependencyError
@seanlinsley seanlinsley merged commit ffa68b3 into activeadmin:master Aug 20, 2014
@timoschilling timoschilling deleted the dependency_error branch August 20, 2014 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timoschilling @seanlinsley