fix and implement missing resource controller specs #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,36 +224,34 @@ def call_after_destroy(obj); end | |||
|
|
|||
| describe "performing batch_action" do | |||
| let(:controller){ Admin::PostsController.new } | |||
| let(:batch_action) { ActiveAdmin::BatchAction.new :flag, "Flag", &batch_action_block } | |||
| let(:batch_action_block) { lambda { |*| } } | |||
There was a problem hiding this comment.
The other option is to use a proc here:
let(:batch_action_block) { proc { } }
seanlinsley
added a commit
that referenced
this pull request
Aug 31, 2014
fix and implement missing resource controller specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
The old 2 skipped tests are failing while this overwrites the rspec
postmethod:To use a
postrequest in a unit spec is not a good choice, while with post you can't expect a internal rised error, you can only expect the external error, so I change it.Commit 2
This is not the best way, but it looks like this is the only one and we don't need to test the right behavior of
instance_exec.