Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use proxy param_key when building forms #3424

Closed
wants to merge 3 commits into from
Closed

Always use proxy param_key when building forms #3424

wants to merge 3 commits into from

Conversation

sindrenm
Copy link

This fixes issue #3423 by always using the proxy param_key method from ActiveAdmin::Resource::Name.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling 2f60776 on sindrenm:3423-use-proxy-param-key into 6472173 on activeadmin:master.

@sindrenm
Copy link
Author

Sooo, this passes on Rails 3.2.19 but fails on 4.1.5. Oh well.

@dmitry
Copy link
Contributor

dmitry commented Sep 25, 2014

Can you please include specs?

@sindrenm
Copy link
Author

@dmitry: Is this something you want specs for? I certainly don't want to spec the delegate method, that's already been specced by someone else. And I don't really want to spec that I call the delegate method either, as that is implementation specific and would break if we changed the implementation to something like this (even though it would still work):

def param_key
  resource_name.param_key
end

@timoschilling
Copy link
Member

@sindrenm That @dmitry ask for specs, is not about specing delegate, its about to show that all use cases for param_key works. Please revert your merges, use rebase on master instead and bring it to run on each version.

@timoschilling
Copy link
Member

I'm going to close this, see #3423 for the reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants