#3044: Use find_by instead of find_by_xxx
#3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -250,7 +250,7 @@ def config(options = {}) | |||
| let(:different_post) { double } | |||
| before do | |||
| allow(Post).to receive(:primary_key).and_return 'something_else' | |||
| allow(Post).to receive(:find_by_something_else).with('55555') { different_post } | |||
| allow(Post).to receive(:find_by).with('something_else' => '55555') { different_post } | |||
There was a problem hiding this comment.
Line is too long. [95/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
avokhmin
changed the title
public_sendfind_by instead of find_by_xxx
| allow(Post).to receive(:find_by). | ||
| with("something_else" => "55555") { different_post } | ||
| else | ||
| allow(Post).to receive(:find_by_something_else).with('55555') { different_post } |
There was a problem hiding this comment.
Line is too long. [92/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Ok, ready for review. |
|
👍 looks good, but the commits are a bit confusing. Would you mind squashing them together? |
| @@ -232,7 +232,11 @@ def config(options = {}) | |||
| let(:resource) { namespace.register(Post) } | |||
| let(:post) { double } | |||
| before do | |||
| allow(Post).to receive(:find_by_id).with('12345') { post } | |||
| if Rails::VERSION::MAJOR > 3 | |||
There was a problem hiding this comment.
I think it's more clear if you write >= 4
avokhmin
force-pushed
the
3044-use-public_send-2
branch
from
4fdc0cb
to
23d47d2
Compare
|
Please squash the last commits too |
avokhmin
force-pushed
the
3044-use-public_send-2
branch
from
23d47d2
to
986b7d0
Compare
|
Updated, sorry for delay, I had a vacation... |
timoschilling
added a commit
that referenced
this pull request
May 19, 2015
#3044: Use `find_by` instead of `find_by_xxx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By #3044 , #3090 and according to http://guides.rubyonrails.org/4_2_release_notes.html#adequate-record
Also, should help to prevent: