Remove unused bourbon gem #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren’t using bourbon mixins to begin with so no need for the dependency.
varyonic
approved these changes
Jun 30, 2017
Fivell
approved these changes
Jun 30, 2017
|
Removing dependencies.. its the best kind of party. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we were using bourbon but realized we weren’t using it to begin with so there is no need for the dependency. We have our own SASS mixins that we use but none from Bourbon. Testing locally against master, our components appear just fine, including things like gradients so this is safe removal now. No need to wait until v2.
I misread #4780 entirely since Bourbon only works with the
@includesyntax and but in our gradient mixin, we provide the explicit value oflinear-gradientforbackground-imageso we weren't even using Bourbon.Fixes #4780 and #4791