Add priority option to action item #5334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5334 +/- ##
==========================================
+ Coverage 98.29% 98.29% +<.01%
==========================================
Files 294 294
Lines 10982 10989 +7
==========================================
+ Hits 10795 10802 +7
Misses 187 187
Continue to review full report at Codecov.
|
|
Interesting idea, I would like to see more feedback from others. My first thought is to add a |
|
@varyonic I think priority is better one, since we already have such option also for sidebar |
There was a problem hiding this comment.
@andreslemik , can you please also add note in documentation about new option here https://github.com/activeadmin/activeadmin/blob/master/docs/8-custom-actions.md#action-items
| @@ -32,6 +32,16 @@ | |||
| expect(resource.action_items.first.html_class).to eq("action_item test") | |||
| end | |||
|
|
|||
| it 'should be ordered by priority' do | |||
| resource.add_action_item :first, priority: 0 do | |||
| # Empty ... | |||
There was a problem hiding this comment.
please also add one action item without priority to this example for testing default priority
Fivell
changed the title
| @@ -110,6 +110,10 @@ def initialize(name, options = {}, &block) | |||
| def html_class | |||
| "action_item #{@options[:class]}".rstrip | |||
| end | |||
|
|
|||
| def priority | |||
| @options[:priority] || 10 | |||
There was a problem hiding this comment.
@andreslemik please fix docs for add_action_item method with including description for new option
There was a problem hiding this comment.
@Fivell, all done
|
@varyonic what do you think ? |
Add priority option to action item (cherry picked from commit a971426)
Able to add action item to the beginning of action items via adding
priority: 0.