Verify support for Rails 5.2 #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5343 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 294 294
Lines 10989 10989
=======================================
Hits 10802 10802
Misses 187 187
Continue to review full report at Codecov.
|
zorab47
approved these changes
Feb 13, 2018
onomojo
reviewed
Apr 12, 2018
| @@ -21,11 +21,11 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'arbre', '>= 1.1.1' | |||
| s.add_dependency 'formtastic', '~> 3.1' | |||
| s.add_dependency 'formtastic_i18n' | |||
| s.add_dependency 'inherited_resources', '~> 1.7' | |||
| s.add_dependency 'inherited_resources', '>= 1.7.0' | |||
| s.add_dependency 'jquery-rails', '>= 4.2.0' | |||
| s.add_dependency 'kaminari', '>= 1.0.1' | |||
| s.add_dependency 'railties', '>= 4.2', '< 5.2' | |||
There was a problem hiding this comment.
This was supposed to be for Rails 5.2 support but you're specifying railties < 5.2. How's that supposed to work? Rails 5.2 requires railties 5.2.0. rails/rails@375a414#diff-e79a60dc6b85309ae70a6ea8261eaf95R81
|
See #5391. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5254. Pending gem releases for devise
and ransack. All tests pass, only a couple of deprecations needed to be addressed.