Backport of Rails 5.2 support #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1-2-stable #5401 +/- ##
=============================================
+ Coverage 97.99% 98.1% +0.11%
=============================================
Files 285 285
Lines 11059 11045 -14
=============================================
- Hits 10837 10836 -1
+ Misses 222 209 -13
Continue to review full report at Codecov.
|
varyonic
reviewed
Apr 17, 2018
activeadmin.gemspec
Outdated
| s.add_dependency 'ransack', '>= 1.8.7' | ||
| s.add_dependency 'sass', '~> 3.4' | ||
| s.add_dependency 'sprockets', '>= 3.0', '< 4.1' | ||
| s.add_dependency 'sprockets-es6', '>= 0.9.2' |
There was a problem hiding this comment.
I think ES6 is 2.0.alpha only?
There was a problem hiding this comment.
Oops, I merged in a bit too much there.
Support of all releases in the 5.2.x branch, but avoid similar issues like those mentioned in #4916.
Require Capybara < 3.0 until the issue is resolved
And remove now unnecessary workaround.
zorab47
force-pushed
the
1-2-stable-backport-of-rails52
branch
from
62105a5
to
4993610
Compare
varyonic
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of Rails 5.2 support to the 1.x branch.