Bundler 2 #5659
Merged
Bundler 2 #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
bundler_2
branch
from
1d9562d
to
72e8b1b
Compare
This reverts commit 97ae562. Version auto-switching is a default feature in bundler 2, so a binstub is no longer needed.
Base ruby docker images where setting the `BUNDLER_VERSION` environment variable. This environment variable is used in bundler 2 to override "lock file bundler version guessing". Setting this environment variable has been removed from the official docker images, so that it doesn't interfere with this feature, but it has not yet been released. So for now we override the `BUNDLER_VERSION` environment variable with the value we want, so that bundler can properly run.
deivid-rodriguez
force-pushed
the
bundler_2
branch
from
72e8b1b
to
43aa1cf
Compare
zorab47
approved these changes
Jan 6, 2019
|
Thanks @zorab47! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the bundler locked version to 2.0.1. Bundler 2 provides version autoswitching according to the version present in the lockfile, so a binstub for bundler itself is no longer needed.
In order for bundler 2 to work in CI, I also needed to override the
BUNDLER_VERSIONenvironment variable because of docker-library/ruby#246. The fix for this has already been added to the official docker images for ruby, but have not yet been deployed. Once the fixed images are available, the overriding of theBUNDLER_VERSIONenvironment variable can be removed.