Update filters disabled error to include specific action #6195
Conversation
|
Is this change significant enough to warrant an entry in |
|
Hi! Sorry for the delay, I'd go with considering this a bug fix! |
| @@ -3,7 +3,7 @@ module Filters | |||
|
|
|||
| class Disabled < RuntimeError | |||
| def initialize | |||
| super "Can't remove a filter when filters are disabled. Enable filters with 'config.filters = true'" | |||
| super "Can't add or remove a filter when filters are disabled. Enable filters with 'config.filters = true'" | |||
There was a problem hiding this comment.
I was thinking we could stop overriding initialize, and do class Disabled < RuntimeError; end, and then pass the correct message for each of the cases instead?
|
That's a worthwhile suggestion so at least the message is specific to the action taking place. @javawizard I'd accept that change if you still want to get this in. Thank you. |
ActiveAdmin::Filters::Disabled is raised both when attempting add a filter and when attempting to remove a filter when filters are disabled. Change the message to suit both use cases.
javierjulio
force-pushed
the
filters-disabled-message-add-or-remove
branch
from
d6a32fa
to
653ab2f
Compare
javierjulio
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6195 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 197 197
Lines 4950 4950
=======================================
Hits 4898 4898
Misses 52 52
☔ View full report in Codecov by Sentry. |
ActiveAdmin::Filters::Disabledis raised both when attempting add a filter and when attempting to remove a filter when filters are disabled. Change the message to suit both use cases.