Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundler 2.2.0.rc.1 #6484

Merged
merged 2 commits into from Oct 2, 2020
Merged

Use bundler 2.2.0.rc.1 #6484

merged 2 commits into from Oct 2, 2020

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Sep 28, 2020

There's a bug in the rake release task that's fixed in the latest bundler rc release and it's preventing me from releasing. I get this:

$ bin/rake release
activeadmin 2.8.1 built to pkg/activeadmin-2.8.1.gem.
Tagged v2.8.1.
Untagging v2.8.1 due to error.
rake aborted!
Couldn't git push. `git push  --tags' failed with the following output:

To https://github.com/activeadmin/activeadmin
 * [new tag]             v2.8.1 -> v2.8.1
 ! [rejected]            v2.7.0 -> v2.7.0 (already exists)
error: failed to push some refs to 'https://github.com/activeadmin/activeadmin'
hint: Updates were rejected because the tag already exists in the remote.

I think I could also fix it by messing with my local tags, but I'd like to try the bundler rc release too.

Bundler 2.2.0 resolves all platforms by default, so it will raise an
error for this inline Gemfile.
There's a bug in the `rake release` task that's fixed in the latest
bundler rc release and it's preventing me from releasing. I get this:

```
$ bin/rake release
activeadmin 2.8.1 built to pkg/activeadmin-2.8.1.gem.
Tagged v2.8.1.
Untagging v2.8.1 due to error.
rake aborted!
Couldn't git push. `git push  --tags' failed with the following output:

To https://github.com/activeadmin/activeadmin
 * [new tag]             v2.8.1 -> v2.8.1
 ! [rejected]            v2.7.0 -> v2.7.0 (already exists)
error: failed to push some refs to 'https://github.com/activeadmin/activeadmin'
hint: Updates were rejected because the tag already exists in the remote.
```

I think I could also fix it by messing with my local tags, but I'd like
to try the bundler rc release too.
@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Oct 2, 2020

This actually revealed an issue with the inline Gemfile in our bug report template, which had incompatible dependencies. Since bundler 2.2 will resolve Gemfiles for all platforms by default, it detected the issue.

This one should be ready!

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@javierjulio javierjulio merged commit 91e4a99 into master Oct 2, 2020
@javierjulio javierjulio deleted the bundler_2_2_0 branch October 2, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants