Get rid of deprecated *_filter support #6960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`*_filter` methods were removed in Rails 5.1, see rails/rails@d7be30e. Should've been done as a part of cdfea4c, so this is just a leftover addressed. BTW `skip_action` added in fc87605 never existed in Rails. `skip_filter` was renamed to `skip_action_callback` in Rails 4.2 rails/rails@6c5f43b and then deprecated in Rails 5.1 rails/rails@6976e1d. Basically this commit reverts the implementation to 2010, similar to 83c1f22 but more complete and up-to-date.
deivid-rodriguez
force-pushed
the
get-rid-of-deprecated-filter-support
branch
from
c7cf84c
to
0fa5b7c
Compare
|
Glad to see this merged. Thanks @javierjulio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*_filtermethods were removed in Rails 5.1, see rails/rails@d7be30e.Should've been done as a part of cdfea4c, so this is just a leftover addressed.
BTW
skip_actionadded in fc87605 never existed in Rails.skip_filterwas renamed toskip_action_callbackin Rails 4.2 rails/rails@6c5f43band then deprecated in Rails 5.1 rails/rails@6976e1d.
Basically this commit reverts the implementation to 2010, similar to 83c1f22 but more complete and up-to-date.