New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.register_javascript with options support #7002
Update config.register_javascript with options support #7002
Conversation
Would love to get this one loaded as hotwire becomes more readily used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you rebase this to make sure CI is ok?
0d18751
to
e0a81ee
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7002 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 197 197
Lines 4950 4950
=======================================
Hits 4901 4901
Misses 49 49
☔ View full report in Codecov by Sentry. |
e0a81ee
to
2810c8c
Compare
options:
support on config.register_javascript
2810c8c
to
04f5a65
Compare
options:
support on config.register_javascript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have replace the turbolink with turbo in my project. so I think it will be better to generate
<script>
tag like belowHowever, the method
register_javascript
don't supportoptions
likeconfig.register_stylesheet
I think it will be a good idea to make it customizable