Prep Tailwind CSS migration part 4 #8116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And pass through to link_to method call
We need this for easier testing
This logic now handles better if a button or anchor is being clicked vs the table row content e.g. text or empty space. Setting the local type variable we set off this prefer-destructuring warning in ESLint but reviewing the docs it seems unsafe so we'll disable it. We can use it where we want but no need to enforce it everywhere.
The rounded borders around the index table can appear as being clipped off partially so this fixes that so it renders normally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8116 +/- ##
=======================================
Coverage 99.04% 99.05%
=======================================
Files 185 185
Lines 4733 4739 +6
=======================================
+ Hits 4688 4694 +6
Misses 45 45
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes more new styles but some are still inline and not migrated to a component class yet. The main focus was around the scopes button bars and flash messages. Include some minor styling updates to other components. Also enables Dark mode detection script for testing.