Format daterange filter input values according to i18n default format #8209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8209 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4017 4018 +1
=======================================
+ Hits 3981 3982 +1
Misses 36 36 ☔ View full report in Codecov by Sentry. |
|
Or might I even suggest to split the method and change it like this? def input_html_options_for(input_name, placeholder)
{ placeholder: placeholder,
value: input_value_for(input_name) }.merge(input_html_options)
end
def input_value_for(input_name)
@object.public_send(input_name).to_date.to_s
rescue
""
end |
Co-authored-by: Geremia Taglialatela <tagliala@users.noreply.github.com>
There was a problem hiding this comment.
@eikes thank you. It would help to have a feature test for this. We have a locale step ("set my locale to") so you should be able to test this with a Capybara assertion that the input value is now set to expected format for the locale.
|
@javierjulio I created a test and the gherkin-linter is happy now as well. |
There was a problem hiding this comment.
@eikes does this work as intended for you locally with the generated app? Granted, I haven't loaded a different locale before but tried with this and I'm not seeing the change, unless I'm misunderstanding it. Although, seems that changing the language on the page will not suffice to see it in the browser which would explain why the date input appears the same for me. Just want to be sure it's working as intended for you. If so, then we'll get this in. Thanks!
| @@ -35,6 +35,20 @@ Feature: Index Filtering | |||
| And I press "Filter" | |||
| Then I should see current filter "title_cont" equal to "<script>alert('hax')</script>" with label "Title contains" | |||
|
|
|||
| Scenario: Daterange Filters Uses Locale Format | |||
There was a problem hiding this comment.
| Scenario: Daterange Filters Uses Locale Format | |
| Scenario: Date range filters use locale format |
|
@eikes can you describe a bit more why you want to make this change and for which version? Note that the default branch of ActiveAdmin is for v4 and we've removed jQuery UI and its date picker. Any date inputs will now be the native HTML date input. From what I can tell, the date input parsed value is always in the same format of |
|
@eikes from what we can tell, what we do currently is meant to be the way so I'm going to close this out. Thanks. Feel free to continue any discussion. |
|
I wasn‘t aware of the switch to the native datepicker. The PR is not needed in this case. |
|
@eikes that makes sense. No worries. We figured that was the case. Thank you for the follow up and confirmation. |
When my locale is
de, I expect my date format to be%d.%m.%Y. The current behavior forces a different format. This PR makes sure, that the default format is used. Just like the formtastic date input does.