Test against Ruby 3.3 #8213
Merged
Test against Ruby 3.3 #8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
chore/test-against-ruby-33
branch
from
bb3140d
to
66f5c5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8213 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4018 4018
=======================================
Hits 3982 3982
Misses 36 36 ☔ View full report in Codecov by Sentry. |
tagliala
force-pushed
the
chore/test-against-ruby-33
branch
2 times, most recently
from
66af1a8
to
245964f
Compare
|
@tagliala LGTM. I'm wondering if we must narrow the matrix to reduce the amount of combinations. For example, since Ruby 3.0 is about to reach EOL we could just test against Rails 7.1. What do you think? |
|
tagliala
force-pushed
the
chore/test-against-ruby-33
branch
3 times, most recently
from
3eb31e8
to
67def72
Compare
Also: - Sort Rails dependencies by newer to match Ruby sorting - Test 3.0 only against 7.1 because 3.0 is about to reach EOL
tagliala
force-pushed
the
chore/test-against-ruby-33
branch
from
67def72
to
7a57619
Compare
mgrunberg
approved these changes
Jan 12, 2024
|
The following should be changed: 
edit: oh, but I should have rights to do that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.