Move pagination translations to active_admin scope #8218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
commented
Jan 7, 2024
javierjulio
force-pushed
the
bugfix/8215-kaminari-translations
branch
from
4dbafe8
to
da92324
Compare
javierjulio
approved these changes
Jan 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8218 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4017 4017
=======================================
Hits 3981 3981
Misses 36 36 ☔ View full report in Codecov by Sentry. |
tagliala
force-pushed
the
bugfix/8215-kaminari-translations
branch
2 times, most recently
from
4dbafe8
to
8079c37
Compare
Active Admin uses the Kaminari gem for pagination, which may also be used by the host application. Moving the translations from `views.pagination` to `active_admin.pagination` prevents potential conflicts. Also remove `html_safe`, since Active Admin will use translations just as a fallback for screen readers Fix activeadmin#8215
tagliala
force-pushed
the
bugfix/8215-kaminari-translations
branch
from
8079c37
to
e714360
Compare
javierjulio
added a commit
that referenced
this pull request
Jan 10, 2024
This was introduced in #8218 but we forgot to update the Upgrading guide.
javierjulio
added
type enhancement
type template update
and removed
type enhancement
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Admin uses the Kaminari gem for pagination, which may also be used by the host application. Moving the translations from
views.paginationtoactive_admin.paginationprevents potential conflicts.Fix #8215