Use Tailwind's darkMode selector strategy #8264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #8186 we've been using TailwindCSS v3.4.0 which had a behavioral change with dark mode, in v3.4.1 this was resolved through tailwindlabs/tailwindcss#12717 with a new dark mode "selector" strategy so we should be using that instead going forward. The documentation update in tailwindlabs/tailwindcss.com#1781 includes some additional context. The "class" strategy remains supported, just the ideal one is this new one.