Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tailwind's darkMode selector strategy #8264

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

javierjulio
Copy link
Member

@javierjulio javierjulio commented Feb 26, 2024

Since #8186 we've been using TailwindCSS v3.4.0 which had a behavioral change with dark mode, in v3.4.1 this was resolved through tailwindlabs/tailwindcss#12717 with a new dark mode "selector" strategy so we should be using that instead going forward. The documentation update in tailwindlabs/tailwindcss.com#1781 includes some additional context. The "class" strategy remains supported, just the ideal one is this new one.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (4fcb727) to head (323a934).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8264   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4018     4018           
=======================================
  Hits         3982     3982           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio merged commit 999f1a1 into master Feb 26, 2024
22 checks passed
@javierjulio javierjulio deleted the tailwind-dark-mode-change branch February 26, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant