Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database_cleaner-active_record directly instead #8372

Merged

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jun 9, 2024

Use database_cleaner-active_record directly, as suggested at https://github.com/DatabaseCleaner/database_cleaner

@tagliala tagliala marked this pull request as ready for review June 9, 2024 17:29
@tagliala tagliala mentioned this pull request Jun 9, 2024
3 tasks
@tagliala tagliala force-pushed the chore/use-database-cleaner-ar branch 2 times, most recently from 46df6f9 to 1fa9f73 Compare June 9, 2024 17:30
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (b2e82f2) to head (a104831).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8372   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4018     4018           
=======================================
  Hits         3982     3982           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio changed the title Update Database Cleaner repo Use database_cleaner-active_record directly instead Jun 9, 2024
@javierjulio javierjulio self-requested a review June 9, 2024 17:36
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Use `database_cleaner-active_record` directly, as suggested at
https://github.com/DatabaseCleaner/database_cleaner
@javierjulio javierjulio force-pushed the chore/use-database-cleaner-ar branch from 1fa9f73 to a104831 Compare June 9, 2024 17:37
@tagliala tagliala merged commit 468096a into activeadmin:master Jun 9, 2024
21 checks passed
@tagliala tagliala deleted the chore/use-database-cleaner-ar branch June 9, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants