Merge pull request #40 from alexesDev/speed_up

Don't remove_child if not needed
activeadmin · Nov 11, 2014 · 7586820 · 7586820
2 parents aa78699 + ff2e038
commit 7586820
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/arbre/element.rb b/lib/arbre/element.rb
@@ -47,7 +47,7 @@ def add_child(child)
 
       if child.respond_to?(:parent)
         # Remove the child
-        child.parent.remove_child(child) if child.parent
+        child.parent.remove_child(child) if child.parent && child.parent != self
         # Set ourselves as the parent
         child.parent = self
       end