Required workflows replacement #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tests, run rspec instead of rake so default rake will still run tests and rubocop locally. We don't want to run rubocop as part of tests since we have a required workflow now that runs this with better GitHub support to render warnings inline with files changed.
javierjulio
force-pushed
the
required-workflows
branch
from
8752c0e
to
f3849f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes inline workflows for basic lints as we now will manage this through GitHub's new Required Workflows feature in our new https://github.com/activeadmin/activeadmin-github-workflows repository.