Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.1 support #873

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

tomascco
Copy link
Contributor

@tomascco tomascco commented Oct 5, 2023

I made this PR similar to #707, trying to keep the same structure:

  • Updated the "main" Gemfile to Rails 7.1
  • Moved the old Gemfile to the gemfiles folder
  • Updated all Gemfiles

rake test passed on my machine with the same output (I think) before this PR

You may also feel free to modify, give feedbacks, etc.

Hope this helps 😄

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3e7a7e5) 98.19% compared to head (036a03e) 98.19%.
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files          14       14           
  Lines         555      555           
=======================================
  Hits          545      545           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll do a separate update to remove the upper bound so we can avoid having to release, assuming no other changes are needed for support. That will close out #711.

@javierjulio javierjulio merged commit b992743 into activeadmin:master Oct 6, 2023
19 checks passed
@javierjulio
Copy link
Member

@tomascco there are several deprecation warnings as a result of updating to Rails 7.1. It would help to have a follow up to resolve those if you or someone else is able too. Thank you.

@tomascco
Copy link
Contributor Author

tomascco commented Oct 6, 2023

Sure, I'll try my best to tackle those warnings 😃

@javierjulio
Copy link
Member

Thank you, I appreciate it! If you have trouble feel free to post what you have in a PR and others can jump in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants