Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Rails 7.0 #707

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Allow Rails 7.0 #707

merged 1 commit into from
Dec 21, 2021

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Dec 16, 2021 •
edited
Loading

Also:

  • Tests against Rails 7.0 by default
  • Updates all the Gemfile.lock

Supersedes #702:

  • Does not remove Ruby 2.5 support
  • Sets compatibility to < 7.1 instead of <= 7.0

Hi, I'm aware of the other PR. I was working on this at the same time. On my fork, all tests are green: https://github.com/tagliala/inherited_resources/pull/2/checks

Feel free to close, pick code from here, or move to #702

@tagliala
Allow Rails 7.0
c85120f 
Also:
- Tests against Rails 7.0 by default
- Updates all the Gemfile.lock
@tagliala tagliala marked this pull request as ready for review December 17, 2021 08:41
@tagliala tagliala mentioned this pull request Dec 17, 2021
Closed
javierjulio
javierjulio approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@javierjulio javierjulio merged commit 95b2c99 into activeadmin:master Dec 21, 2021
@tagliala tagliala deleted the feature/railties-7 branch December 21, 2021 08:31
@tagliala tagliala mentioned this pull request Dec 21, 2021
Merged
11 tasks
@baarkerlounger
Copy link

Will there be a versioned release now that this has been merged?

@tagliala
Copy link
Contributor Author

tagliala commented Dec 29, 2021 •
edited
Loading

Will there be a versioned release now that this has been merged?

I'm also asking if it is possible to release a new version of this gem, for the following reasons:

@tomascco tomascco mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

@varyonic varyonic varyonic approved these changes

@alejandroperea alejandroperea alejandroperea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tagliala @baarkerlounger @javierjulio @varyonic @alejandroperea