Cleanup #12
Open
Cleanup #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freelock
pushed a commit
to freelock/purl-d8
that referenced
this pull request
Oct 16, 2021
Extend with new alter, where we can modify matched modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other small cleanup items -- plugin annotation that I tried when trying to generate plugin instances, may or may not be important, and a fix for a conflict with the core Webprofiler module.
The module in general needs a cleanup from coder/phpcbf, as there are lots of code style warnings, but can do this after this set of PRs are merged, as the cleanup will affect just about every file.