Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataset/tensor
info
alongsidemeta
#1066dataset/tensor
info
alongsidemeta
#1066Changes from 29 commits
be6ce00
ea459f3
96fb8a5
d11920f
bfc97f3
0cb390a
40b902d
161d9e2
60f9171
43bc04f
bfb8876
338b949
5e51ed2
52a65f1
ac33b0d
e491547
0542988
39f64d7
55f99f5
a1da0a9
46faf5a
e792f99
d7745e7
723a61a
173da03
fbed709
2a14a88
930a0ed
a212d37
d1f6faf
5959dfb
3b1d992
4cfc707
59a99dd
cd06615
ba8095e
f447bda
19160c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 additional small files -- this means that in total we will have the following small files:
for a dataset with 2 tensors, there will be 8 small files.
for a dataset with 4 tensors there will be 14 small files.
the more tensors we add, the more small files they will contain. this isn't a problem now, but we should keep it in mind as we proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced
len
withnbytes
for all cachables so that cachable classes can have theirlen
computed without returning the num bytes.