Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-[1706] throw exception it commiting unchanged dataset #1535

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Mar 11, 2022

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 11, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 11, 2022
@levongh levongh changed the title throw exception it commiting unchanged dataset AL-[1706] throw exception it commiting unchanged dataset Mar 12, 2022
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #1535 (2fac5a9) into main (98c4cbe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1535   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         191      191           
  Lines       17004    17021   +17     
=======================================
+ Hits        15710    15727   +17     
  Misses       1294     1294           
Flag Coverage 螖
unittests 92.39% <100.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
hub/core/dataset/dataset.py 93.20% <100.00%> (+0.01%) 猬嗭笍
hub/core/version_control/test_version_control.py 99.88% <100.00%> (+<0.01%) 猬嗭笍
hub/util/exceptions.py 80.20% <100.00%> (+0.13%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 98c4cbe...2fac5a9. Read the comment docs.

@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 14, 2022

Returns:
str: the commit id of the stored commit that can be used to access the snapshot.

Raises:
Exception: if dataset is a filtered view.
EmptyCommitError: if there are no changes and user does not forced to commit unchanged data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EmptyCommitError: if there are no changes and user does not forced to commit unchanged data
EmptyCommitError: if there are no changes and `allow_empty` is not True.

@levongh levongh added the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Mar 14, 2022
@levongh levongh merged commit 1c8784c into main Mar 14, 2022
@levongh levongh deleted the lg_ds_commit branch March 14, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants