Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tiny] Fix empty commits checking logic #1557

Closed
wants to merge 1 commit into from
Closed

[Tiny] Fix empty commits checking logic #1557

wants to merge 1 commit into from

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Fixes improper behaviour being caused due to #1535

@AbhinavTuli
Copy link
Contributor Author

Actually, this isn't needed current behaviour is fine.

@AbhinavTuli AbhinavTuli deleted the fix/empty_commits branch June 8, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farizrahman4u farizrahman4u farizrahman4u approved these changes

@levongh levongh levongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhinavTuli @farizrahman4u @levongh