Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1766] hub.copy fix (2) + small refac #1644

Merged
merged 2 commits into from
May 2, 2022
Merged

[AL-1766] hub.copy fix (2) + small refac #1644

merged 2 commits into from
May 2, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@farizrahman4u farizrahman4u changed the title [AL-1766] hub.copy fix (2) [AL-1766] hub.copy fix (2) + small refac May 1, 2022
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1644 (38288fa) into main (d1b41e7) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   92.53%   91.84%   -0.69%     
==========================================
  Files         219      219              
  Lines       21164    20859     -305     
==========================================
- Hits        19584    19158     -426     
- Misses       1580     1701     +121     
Flag Coverage Δ
unittests 91.84% <100.00%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/fast_forwarding.py 71.66% <100.00%> (+7.15%) ⬆️
hub/core/meta/tensor_meta.py 87.33% <100.00%> (-0.34%) ⬇️
hub/api/tests/test_sample_info.py 72.72% <0.00%> (-27.28%) ⬇️
hub/api/tests/test_api_with_compression.py 88.15% <0.00%> (-11.85%) ⬇️
hub/core/compression.py 80.09% <0.00%> (-9.31%) ⬇️
hub/integrations/tf/hubtensorflowdataset.py 66.27% <0.00%> (-7.83%) ⬇️
hub/core/tests/test_compression.py 94.44% <0.00%> (-5.56%) ⬇️
hub/tests/path_fixtures.py 87.21% <0.00%> (-3.25%) ⬇️
hub/tests/storage_fixtures.py 88.88% <0.00%> (-2.23%) ⬇️
hub/core/sample.py 84.21% <0.00%> (-2.09%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b41e7...38288fa. Read the comment docs.

@farizrahman4u farizrahman4u merged commit e41e1c8 into main May 2, 2022
@farizrahman4u farizrahman4u deleted the fr_copy_fix_2 branch May 2, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants