Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-2308] check linked creds expiration #2404

Merged
merged 6 commits into from
Jun 4, 2023

Conversation

levongh
Copy link
Contributor

@levongh levongh commented Jun 2, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Francesco Saverio Zuppichini and others added 4 commits June 2, 2023 09:19
* Update deeplake_cloud_dataset.py

added missing `ds_name` field

* Update deeplake_cloud_dataset.py

updated after review

* Update deeplake_cloud_dataset.py

fixed typo

* non-local org_id error

* test

---------

Co-authored-by: FayazRahman <fayazrahman4u@gmail.com>
* Updated README.md

- included comparison with MosaicML,
- Database for ai verbiage
- updated the academic plan

* Update README.md
@tatevikh tatevikh changed the title check linked creds expiration [AL-2308] check linked creds expiration Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.03 ⚠️

Comparison is base (c0a4e29) 84.73% compared to head (826ff31) 84.71%.

❗ Current head 826ff31 differs from pull request most recent head a61d1fc. Consider uploading reports for the commit a61d1fc to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                   @@
##           temp_expiration_fix    #2404      +/-   ##
=======================================================
- Coverage                84.73%   84.71%   -0.03%     
=======================================================
  Files                      323      323              
  Lines                    36729    36746      +17     
=======================================================
+ Hits                     31124    31128       +4     
- Misses                    5605     5618      +13     
Flag Coverage Δ
unittests 84.71% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/core/link_creds.py 91.21% <40.00%> (-1.29%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@levongh levongh merged commit c7b9e01 into temp_expiration_fix Jun 4, 2023
@levongh levongh deleted the linked_creds_expiration branch June 4, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants