Addressing Sonar-found bugs and code smells. #2487

nvoxland · 2023-07-17T18:45:31Z

🚀 🚀 Pull Request

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)
Code cleanup

Working through "bug" and "code smell" sections of the sonar report.

The one "bug" was test_delete_and_commit() missing an assert

The rest were "code smells":

Variables in tests that were unneeded to set
Functions that define input/output types as something like str but are passed or return None, so I added Optional to type
Switched f"" strings to regular strings if there was no substitution
Don't use insecure http urls (this was in the security section)

Should not change functionality, just clean up code

Nothing

Primarily: - Unused variables - Missing "Optional" in type definitions

Addressing sonar-found bugs and bad code smells.

ddfac94

Primarily: - Unused variables - Missing "Optional" in type definitions

nvoxland requested a review from artgish July 17, 2023 18:50

Use https for test download to avoid sonar complaints

3c07f6a

tatevikh requested review from FayazRahman and adolkhan July 20, 2023 13:43

adolkhan approved these changes Jul 20, 2023

View reviewed changes

artgish approved these changes Jul 20, 2023

View reviewed changes

nvoxland removed the request for review from FayazRahman July 20, 2023 18:20

tatevikh and others added 3 commits July 20, 2023 14:23

Merge branch 'main' into sonar-bugs-and-smells

0028e96

Merge branch 'main' into sonar-bugs-and-smells

dbcb3a3

Merge branch 'main' into sonar-bugs-and-smells

7ebab7f

nvoxland merged commit aac3873 into main Jul 21, 2023
4 of 7 checks passed

nvoxland deleted the sonar-bugs-and-smells branch July 21, 2023 15:02