Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "V4 changes, Indra adaptors (#2733)" #2822

Closed
wants to merge 1 commit into from
Closed

Revert "V4 changes, Indra adaptors (#2733)" #2822

wants to merge 1 commit into from

Conversation

khustup2
Copy link
Contributor

@khustup2 khustup2 commented Apr 5, 2024

This PR is for testing purposes, to check what causes windows tests failure.
This reverts commit e75c56c.

馃殌 馃殌 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@khustup2 khustup2 added the full-tests Trigger Full versioned OS tests label Apr 5, 2024
@khustup2 khustup2 marked this pull request as ready for review April 5, 2024 07:45
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 15 lines in your changes are missing coverage. Please review.

Files Patch % Lines
deeplake/core/dataset/deeplake_query_dataset.py 87.03% 7 Missing 鈿狅笍
deeplake/enterprise/convert_to_libdeeplake.py 55.55% 4 Missing 鈿狅笍
deeplake/core/dataset/deeplake_query_tensor.py 83.33% 3 Missing 鈿狅笍
deeplake/core/dataset/view_entry.py 66.66% 1 Missing 鈿狅笍

馃摙 Thoughts on this report? Let us know!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarCloud

@khustup2 khustup2 closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
full-tests Trigger Full versioned OS tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@khustup2