Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #371] Add Github Actions CI pipeline #372

Merged
merged 9 commits into from
Feb 19, 2021

Conversation

ADI10HERO
Copy link
Contributor

@ADI10HERO ADI10HERO commented Dec 23, 2020

fixes #371

This patch adds GitHub actions CI pipeline.

CI pipeline:

  • Creates multiple environments
  • Installs requirements and HUB
  • Lints code with Black
  • Runs pytest and codecov

Signed-off-by: Aditya Srivastava <adityasrivastava301199@gmail.com>
Signed-off-by: Aditya Srivastava <adityasrivastava301199@gmail.com>
@github-actions
Copy link

Locust summary

Git references

Initial: 76ab210
Terminal: 3a09cb6

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #372 (a869971) into master (3fdea4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          53       53           
  Lines        3881     3881           
=======================================
  Hits         3464     3464           
  Misses        417      417           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fdea4c...a869971. Read the comment docs.

Signed-off-by: Aditya Srivastava <adityasrivastava301199@gmail.com>
Signed-off-by: Aditya Srivastava <adityasrivastava301199@gmail.com>
@davidbuniat
Copy link
Member

This looks great! @ADI10HERO we need to this all fixed, let us know how we can help to make all the checks.

  • add credentials for s3, azure, GCP to be able to test those external services, feel free to point me where to add those creds and I will do it similar to CircleCI
  • To fix the issues, @edogrigqv2 do you think we should get rid of lmdb dependency?
  • ubuntu 64x has this issue AttributeError: module 'hub.api' has no attribute 'objectview'
  • AttributeError: module 'numcodecs' has no attribute 'MsgPack'
  • c:\hostedtoolcache\windows\python\3.7.9\x64\lib\posixpath.py:248: ModuleNotFoundError on windows
  • assertion errors on windows regarding in unit8
  • ModuleNotFoundError: No module named 'pwd' not found on windows
  • More issues.

@Anselmoo
Copy link
Contributor

@ADI10HERO there are two points, which I want to add:

  1. Why are you running once with and without optional dependencies the same test because it pyetest runs in both cases the exactly the same tests. I would recommend if that not cause some of your fail tests.
  2. Also I can recommend adding https://github.com/darrenburns/pytest-clarity which provides a better visualization of the fail tests.

remove temporarily tests and coverage, just to test building the package across platforms
remove 3.9 support
@davidbuniat
Copy link
Member

We removed 3.9 and pytests in order to test installation on cross-platform. @Anselmoo will add two feature requests to make sure Hub is properly working across all OS and 3.9 python.

@davidbuniat davidbuniat merged commit b0b0ba1 into activeloopai:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Github Action CI Pipeline for packaging HUB
3 participants