Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited message for transform computation #523

Merged

Conversation

DebadityaPal
Copy link
Contributor

@AbhinavTuli, I have edited the description of the transform computation as we discussed in Slack.

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

Locust summary

Git references

Initial: 31943d2
Terminal: a3f3cc5

hub/compute/transform.py
Changes:
  • Name: Transform
    Type: class
    Changed lines: 1
    Total lines: 399
    Changes:

@haiyangdeperci
Copy link
Contributor

haiyangdeperci commented Feb 1, 2021

@DebadityaPal thanks for sending this in. Can you change the word transormation to transformation? It's a typo.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #523 (9fb49ed) into master (31943d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          52       52           
  Lines        3745     3745           
=======================================
  Hits         3313     3313           
  Misses        432      432           
Impacted Files Coverage Δ
hub/compute/transform.py 93.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31943d2...9fb49ed. Read the comment docs.

@DebadityaPal
Copy link
Contributor Author

DebadityaPal commented Feb 1, 2021

@haiyangdeperci, I'm sorry, My bad. It shouldn't have escaped my notice.

@haiyangdeperci
Copy link
Contributor

@DebadityaPal no worries, you are doing a great job 👍
I think it's ready to be merged @AbhinavTuli

@AbhinavTuli
Copy link
Contributor

Yes, it looks good. Merging now :)

@AbhinavTuli AbhinavTuli merged commit e32e937 into activeloopai:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants