Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for dataset views in sharded dataset #557

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

AbhinavTuli
Copy link
Contributor

No description provided.

@github-actions
Copy link

Locust summary

Git references

Initial: 6f8927c
Terminal: 413d563

hub/api/sharded_datasetview.py
Changes:
hub/api/tests/test_sharded_dataset.py
Changes:

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #557 (f5a3329) into master (6f8927c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +0.01%     
==========================================
  Files          52       52              
  Lines        3772     3776       +4     
==========================================
+ Hits         3369     3373       +4     
  Misses        403      403              
Impacted Files Coverage Δ
hub/api/datasetview.py 92.51% <100.00%> (+0.15%) ⬆️
hub/api/sharded_datasetview.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f8927c...f5a3329. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 09e3998 into master Feb 18, 2021
@AbhinavTuli AbhinavTuli deleted the fixes/sharded_dataset branch March 21, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants