New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced slicing added for Sharded Dataset #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locust summaryGit referencesInitial: f5a3329Terminal: 1a8bd16 hub/api/compute_list.pyChanges:
hub/api/sharded_datasetview.pyChanges:
hub/api/dataset.pyChanges:
hub/api/datasetview.pyChanges:
hub/api/tests/test_sharded_dataset.pyChanges:
|
AbhinavTuli
force-pushed
the
feature/sharded_ds_advanced_slicing
branch
from
February 15, 2021 16:21
fb675f9
to
1a8bd16
Compare
AbhinavTuli
force-pushed
the
feature/sharded_ds_advanced_slicing
branch
from
February 15, 2021 17:35
cdc5ce9
to
4ecd521
Compare
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 89.32% 89.39% +0.06%
==========================================
Files 52 53 +1
Lines 3776 3819 +43
==========================================
+ Hits 3373 3414 +41
- Misses 403 405 +2
Continue to review full report at Codecov.
|
kristinagrig06
approved these changes
Feb 18, 2021
davidbuniat
requested changes
Feb 19, 2021
davidbuniat
approved these changes
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds advanced (cross shard) slicing to Sharded Dataset. Need to wait for #557 before merging to master.