Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced slicing added for Sharded Dataset #558

Merged
merged 6 commits into from Feb 21, 2021

Conversation

AbhinavTuli
Copy link
Contributor

Adds advanced (cross shard) slicing to Sharded Dataset. Need to wait for #557 before merging to master.

@github-actions
Copy link

Locust summary

Git references

Initial: f5a3329
Terminal: 1a8bd16

hub/api/compute_list.py
Changes:
hub/api/sharded_datasetview.py
Changes:
hub/api/dataset.py
Changes:
  • Name: Dataset
    Type: class
    Changed lines: 2
    Total lines: 1150
    Changes:
hub/api/datasetview.py
Changes:
hub/api/tests/test_sharded_dataset.py
Changes:

@AbhinavTuli AbhinavTuli force-pushed the feature/sharded_ds_advanced_slicing branch from fb675f9 to 1a8bd16 Compare February 15, 2021 16:21
@AbhinavTuli AbhinavTuli force-pushed the feature/sharded_ds_advanced_slicing branch from cdc5ce9 to 4ecd521 Compare February 15, 2021 17:35
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #558 (9cc562f) into master (f5a3329) will increase coverage by 0.06%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   89.32%   89.39%   +0.06%     
==========================================
  Files          52       53       +1     
  Lines        3776     3819      +43     
==========================================
+ Hits         3373     3414      +41     
- Misses        403      405       +2     
Impacted Files Coverage Δ
hub/exceptions.py 100.00% <ø> (ø)
hub/api/compute_list.py 90.00% <90.00%> (ø)
hub/api/sharded_datasetview.py 98.79% <97.95%> (-1.21%) ⬇️
hub/api/dataset.py 89.63% <100.00%> (ø)
hub/api/datasetview.py 92.56% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a3329...9cc562f. Read the comment docs.

@AbhinavTuli AbhinavTuli changed the base branch from fixes/sharded_dataset to master February 18, 2021 11:23
hub/api/sharded_datasetview.py Show resolved Hide resolved
hub/api/sharded_datasetview.py Show resolved Hide resolved
@davidbuniat davidbuniat merged commit 30f2c4e into master Feb 21, 2021
@AbhinavTuli AbhinavTuli deleted the feature/sharded_ds_advanced_slicing branch March 22, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants