Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README_CN.md Proofread and Update #613

Merged
merged 6 commits into from
Mar 1, 2021

Conversation

Cynthia7979
Copy link
Contributor

  • Proofread. Enhanced overall fluency and translation accuracy
  • Changed English commas to Chinese "、" in "and"/"or" sentences
  • Translated multiple new sections (see below). This README is now up-to-date with README.md.
    • Visualization example
    • Tutorial Notebooks table
    • .commit() => .flush() See commit 7e5e40e
    • Add link to README_TR
    • Add & Translate "Why Hub specifically?" Section (See commit 966b944)

Note: My last commit, bb8dd54, is actually done according to 966b944, though I wrote d6d4e2f... Seems like I confused commit ID and parent ID...

Updated to "Getting Started"
* English commas to Chinese "、" for and/or-connected sentences.
* Add visualization example according to `README.md`
* General fluency enhance
* General fluency enhancing
* Updated tutorial notebooks table but didn't translate
* commit => flush
* 数据库=>数据集
* "Why Hub specifically?" Section
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #613 (98a0065) into master (3639a0c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files          54       54           
  Lines        3927     3927           
=======================================
  Hits         3508     3508           
  Misses        419      419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3639a0c...98a0065. Read the comment docs.

@haiyangdeperci
Copy link
Contributor

Hi @Cynthia7979. Thanks a lot for keeping the readme up to date. Great job! @mynameisvinn

@Cynthia7979
Copy link
Contributor Author

I just updated the README to resolve new conflicts. Just to ask - when will this PR be merged?

@haiyangdeperci
Copy link
Contributor

Thanks for your patience, @Cynthia7979. Sorry for the wait. I assume @mynameisvinn needed you to update your PR. Now it is ready to be merged. I'll do it right now.

Thanks again for helping us out!

@haiyangdeperci haiyangdeperci merged commit da5c1a5 into activeloopai:master Mar 1, 2021
@mynameisvinn mynameisvinn self-requested a review March 1, 2021 16:28
@mynameisvinn mynameisvinn added the documentation Improvements or additions to documentation label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants