Add logging of SSL connection details #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
force-pushed
the
log-ssl-conn-details
branch
from
7266f70
to
de0f555
Compare
On June 30 the PCI DSS mandates TLS 1.1 or better for securely transmitting payment data. This refinement to Net::HTTP allows us to get the required details within the scope of the ActiveMerchant::Connection class, without monkey patching globally. Example output: ``` irb(main):004:0> gw.authorize(100, "test") I, [2018-05-30T11:22:44.565084 #44620] INFO -- : [ActiveMerchant::Billing::PayflowGateway] connection_http_method=POST connection_uri=https://payflowpro.paypal.com I, [2018-05-30T11:22:45.165265 #44620] INFO -- : [ActiveMerchant::Billing::PayflowGateway] connection_ssl_version=TLSv1.2 connection_ssl_cipher=ECDHE-RSA-AES128-GCM-SHA256 ```
bdewater
force-pushed
the
log-ssl-conn-details
branch
from
de0f555
to
6c770e6
Compare
elfassy
reviewed
May 30, 2018
| require 'net/http' | ||
|
|
||
| module NetHttpSslConnection | ||
| refine Net::HTTP do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On June 30 the PCI DSS mandates TLS 1.1 or better for securely transmitting payment data. This refinement to Net::HTTP allows us to get the required details within the scope of the ActiveMerchant::Connection class, without monkey patching globally.
Example output: