Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openpay: support payment installments #2865

Closed
wants to merge 1 commit into from
Closed

Openpay: support payment installments #2865

wants to merge 1 commit into from

Conversation

bpollack
Copy link
Contributor

Remote tests currently fail, I think because I'm misunderstanding how
to use the API, but I'm not yet sure.

Unit: 20 tests, 102 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: N/A

@bpollack bpollack changed the title DNM: OpenPay: support payment installments DNM: Openpay: support payment installments May 31, 2018
@bpollack bpollack changed the title DNM: Openpay: support payment installments Openpay: support payment installments Jun 5, 2018
@dtykocki
Copy link

dtykocki commented Jun 5, 2018 •
edited
Loading

:angry_homer: Come on Travis!

Locally, on master, I'm seeing four remote test failures that I think could be fixed up. The test_successful_purchase_with_card_stored fails with message "Please specify a valid source_id". Maybe we can provide a source_id to make this one pass?

The remaining three failures are:

"The card is not supported on online transactions" expected but was "The card was declined".

It's your call here, but just the message for these failures could be changed.

@bpollack
Copy link
Contributor Author

bpollack commented Jun 5, 2018

You'll be happy to know I fixed Travis in 3efa5c9 and f75f57e , but I hadn't rebased yet; just did so and re-pushed, so Travis should go well.

And that's fair on the remotes. I generally avoid touching those if they've been working in prod since they occasionally require adapter tweaks, but you're right that these are pretty straightforward test-local changes. I'll take a look tomorrow.

nfarve
nfarve approved these changes Jun 6, 2018
View reviewed changes
Copy link

@nfarve nfarve left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 per successful remote tests.

@bpollack
Openpay: support payment installments
4d5cab4 
One remote test fails with a 3DS-related error, but it does prior to
this commit also.

Unit: 20 tests, 102 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 24 tests, 80 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
95.8333% passed
@bpollack
Copy link
Contributor Author

bpollack commented Jun 6, 2018 •
edited
Loading

Okay, @dtykocki I fixed everything but the source_id error, which seems like it might be 3DS-related, but at any rate isn't documented in the Openpay documentation. (The 3DS guess is from tracking down some Google rambling.) This gets us down to one remote failure.

dtykocki
dtykocki approved these changes Jun 6, 2018
View reviewed changes
Copy link

@dtykocki dtykocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks for fixing the tests!

@bpollack bpollack closed this in 9190252 Jun 6, 2018
@bpollack bpollack deleted the enrg-7536-openpay-gsf branch June 6, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtykocki dtykocki dtykocki approved these changes

@nfarve nfarve nfarve approved these changes

@curiousepic curiousepic Awaiting requested review from curiousepic

@deedeelavinder deedeelavinder Awaiting requested review from deedeelavinder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpollack @dtykocki @nfarve