GlobalCollect: Don't overwrite contactDetails #2915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there was an address provided, it would overwrite the contactDeatails field which may have already had an email field added. Now we have a conditional for both email and phone number elements within contactDetails. Also updates the sandbox url to the current endpoint. Remote: 16 tests, 37 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 17 tests, 79 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
bpollack
reviewed
Jul 5, 2018
| post['order']['contactDetails'] = { | ||
| 'emailAddress' => options[:email] | ||
| } | ||
| post['order']['contactDetails']['emailAddress'] = options[:email] if options[:email] |
There was a problem hiding this comment.
Do we know that post['order']['contactDetails'] will always be defined here? I'm wondering if it might be worth adding post['order']['contactDetails'] ||= {} before this line. That might be redundant though.
There was a problem hiding this comment.
I don't see where/why it would be defined before this point...? I guess I am generating an interstitial envelope and its own subfield at the same time, though... is that a nono?
There was a problem hiding this comment.
Okay, nestable_hash makes this work, so ship it!
| 'emailAddress' => options[:email], | ||
| 'phoneNumber' => address[:phone] | ||
| } | ||
| post['customer']['contactDetails']['emailAddress'] = options[:email] if options[:email] |
There was a problem hiding this comment.
Same here; wondering if we need post['customer']['contactDetails'] ||= {} to be safe.
bpollack
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there was an address provided, it would overwrite the
contactDeatails field which may have already had an email field added.
Now we have a conditional for both email and phone number elements
within contactDetails.
Also updates the sandbox url to the current endpoint.
Remote:
16 tests, 37 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
17 tests, 79 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed