Decidir: Add Naranja Card #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtykocki
reviewed
Aug 22, 2019
| @@ -99,7 +99,8 @@ def scrub(transcript) | |||
| transcript. | |||
| gsub(%r((apikey: )\w+)i, '\1[FILTERED]'). | |||
| gsub(%r((\"card_number\\\":\\\")\d+), '\1[FILTERED]'). | |||
| gsub(%r((\"security_code\\\":\\\")\d+), '\1[FILTERED]') | |||
| gsub(%r((\"security_code\\\":\\\")\d+), '\1[FILTERED]'). | |||
| gsub(%r((\"emv_issuer_data\\\":\\\")\d+), '\1[FILTERED]') | |||
There was a problem hiding this comment.
Is the emv_issuer_data something new that comes through in the response?
There was a problem hiding this comment.
I'm not sure. I think so -- it seems to just be the security code repeated which causes the existing scrub test to fail. However, I didn't see anything about it in the docs when I looked. So not exactly sure what the reasoning behind it is.
EVS-181 Adds Naranha card to Decidir gateway Updated two tests to correspond to changed Decidir responses Unit: 22 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 17 tests, 60 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
hdeters
force-pushed
the
EVS-181_add_naranja_to_decidir
branch
from
47eeb8e
to
b80e7d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVS-181
Adds Naranha card to Decidir gateway
Updated two tests to correspond to changed Decidir responses
Unit:
22 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
17 tests, 60 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed