Paymentez: Correct refund and void message parsing

[Carrigan]

Why?

• Per the Paymentez docs, the refund action response has a different shape than other responses from this gateway: https://paymentez.github.io/api-doc/#payment-methods-cards-refund

{"status": "success", "detail": "Completed"}

• ActiveMerchant parses the success field of these messages correctly, but not the messages.
  • Success field:

    active_merchant/lib/active_merchant/billing/gateways/paymentez.rb

    Lines 232 to 234 in cee8dff

    	def success_from(response)
    	!response.include?('error') && (response['status'] || response['transaction']['status']) == 'success'
    	end

  • Message field:

    active_merchant/lib/active_merchant/billing/gateways/paymentez.rb

    Lines 243 to 249 in cee8dff

    	def message_from(response)
    	if !success_from(response) && response['error']
    	response['error'] && response['error']['type']
    	else
    	response['transaction'] && response['transaction']['message']
    	end
    	end

What Changed?

• Changed the Paymentez unit test void/refund payload shape to match the specs.
• Added checks on Paymentez unit and remote tests for nil message values.
• Added proper message handling for Paymentez void and refunds.

Test Validation

To capture the failures, the following tests were added to check for a non-nil value for the and failed at first:

Failure: test_successful_void(RemotePaymentezTest): <nil> was expected to not be nil.
Failure: test_successful_void_with_elo(RemotePaymentezTest): <nil> was expected to not be nil.
Failure: test_successful_refund(RemotePaymentezTest): <nil> was expected to not be nil.
Failure: test_successful_refund_with_elo(RemotePaymentezTest): <nil> was expected to not be nil.
Failure: test_failed_refund(PaymentezTest): <nil> was expected to not be nil.
Failure: test_failed_void(PaymentezTest): <nil> was expected to not be nil.
Failure: test_partial_refund(PaymentezTest): <nil> was expected to not be nil.
Failure: test_successful_void(PaymentezTest): <nil> was expected to not be nil.

This PR includes the changes to make these tests pass.

Test Suite Results

Unit tests:

23 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote tests:

26 tests, 64 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
92.3077% passed

Note: the two failing remote tests are not related to these changes and are failing on master:

• test_partial_capture
• test_successful_authorize_and_capture_with_different_amount

[leila-alderman]

I think it's worth checking the actual content of the message field throughout the unit tests since we're specifying the responses.

Suggested change

	assert_not_nil response.message
	assert_equal 'Completed', response.message

[Carrigan]

Added fixes above. Test suite has not changed:

Unit:

23 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:

26 tests, 64 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
92.3077% passed

[leila-alderman]

Looks good! 💯

[Carrigan]

Thanks @leila-alderman