Shift4: Fixing currency bug #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naashton
approved these changes
Sep 14, 2023
Summary: ------------------------------ Fixes a bug for Shift4 gateway to ensure that currency code is downcased. SER-811 Remote Test: ------------------------------ Finished in 34.37861 seconds. 34 tests, 121 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 47.584817 seconds. 5604 tests, 78022 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 766 files inspected, no offenses detected
naashton
force-pushed
the
Shift4_v2_fixing_currency_bug
branch
from
c76f30f
to
98f0c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a bug for Shift4 gateway to ensure that currency code is downcased.
SER-811
Tests
Remote Test:
Finished in 34.37861 seconds.
34 tests, 121 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit Tests:
Finished in 47.584817 seconds.
5604 tests, 78022 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
766 files inspected, no offenses detected