IPG: support merchant aggregator credentials. #4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinHaefele
force-pushed
the
ipg-credentials-update
branch
from
2a22987
to
0e4cce9
Compare
DustinHaefele
commented
Dec 13, 2023
| @amount = 100 | ||
| @credit_card = credit_card('5165850000000008', brand: 'mastercard', verification_value: '987', month: '12', year: '2029') | ||
| @credit_card = credit_card('5165850000000008', brand: 'mastercard', month: '12', year: '2029') |
There was a problem hiding this comment.
removed the verification_value because their api kept responding "CVV checks not supported on this card"
DustinHaefele
commented
Dec 13, 2023
| @@ -101,10 +101,10 @@ def test_failed_purchase | |||
| end | |||
|
|
|||
| def test_failed_purchase_with_passed_in_store_id | |||
| # passing in a bad store id results in a 401 unauthorized error | |||
There was a problem hiding this comment.
Updated this because they do fail the transaction when the store_id doesn't match but it doesn't respond with a 401.
aenand
approved these changes
Dec 13, 2023
|
@DustinHaefele can you also remove the scrubbing of store_id? this is not a sensitive bit of information |
@aenand done! |
unit tests: 31 tests, 133 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed remote tests: 19 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed spreedly ticket: ECS-3297
DustinHaefele
force-pushed
the
ipg-credentials-update
branch
from
5ca80b3
to
75f4316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests:
31 tests, 133 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
remote tests:
19 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
spreedly ticket: ECS-3297