Cybersource Rest: Stored Credential refactor #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
force-pushed
the
cyber_source_rest_updates
branch
from
0016a8c
to
ea201c5
Compare
aenand
changed the title
almalee24
reviewed
Apr 26, 2024
almalee24
reviewed
Apr 26, 2024
almalee24
reviewed
Apr 30, 2024
almalee24
reviewed
Apr 30, 2024
almalee24
reviewed
Apr 30, 2024
almalee24
reviewed
Apr 30, 2024
almalee24
reviewed
Apr 30, 2024
aenand
force-pushed
the
cyber_source_rest_updates
branch
from
2efb5d1
to
31b74f4
Compare
|
@almalee24 we heard back from Cybersource and have updated the stored credential fields. It is not the same values as the legacy integration. notably, |
almalee24
reviewed
May 31, 2024
DustinHaefele
approved these changes
Jun 4, 2024
aenand
force-pushed
the
cyber_source_rest_updates
branch
from
1b42695
to
877248e
Compare
COMP-78 Refactors the stored credential support for the Cybersource Rest gateway to be in-line with their documentation. Also repairs test suite for this gateway by eliminating certain tests and fixing others. Test summary: Local: 5838 tests, 79156 assertions, 2 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.5718% passed Unit: 30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 43 tests, 143 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
aenand
force-pushed
the
cyber_source_rest_updates
branch
from
877248e
to
5bdffb2
Compare
edgarv09
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Cybersource Rest: Stored Credential refactor COMP-78 Refactors the stored credential support for the Cybersource Rest gateway to be in-line with their documentation. Also repairs test suite for this gateway by eliminating certain tests and fixing others. Test summary: Local: 5838 tests, 79156 assertions, 2 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.5718% passed Unit: 30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 43 tests, 143 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed * PR feedback * pending * wip * remove old code * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMP-78
Refactors the stored credential support for the Cybersource Rest
gateway to be in-line with their documentation. Also repairs test
suite for this gateway by eliminating certain tests and fixing
others.
Test summary:
Local:
5838 tests, 79156 assertions, 2 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications
99.5718% passed
Unit:
30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
43 tests, 143 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed